Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix k8s deployment fail #10747

Merged
merged 3 commits into from Aug 13, 2018
Merged

fix k8s deployment fail #10747

merged 3 commits into from Aug 13, 2018

Conversation

musienko-maxim
Copy link
Contributor

@musienko-maxim musienko-maxim commented Aug 13, 2018 •
edited by riuvshin

@musienko-maxim musienko-maxim self-assigned this Aug 13, 2018
@musienko-maxim musienko-maxim requested review from riuvshin and a user August 13, 2018 09:08
@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Aug 13, 2018
sleshchenko
sleshchenko approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider changing the PR title since it will be used in changelogs

@riuvshin riuvshin changed the title fix ka vosems deployment fail fix k8s deployment fail Aug 13, 2018
@riuvshin riuvshin merged commit 976842f into master Aug 13, 2018
@riuvshin riuvshin deleted the musienko-maxim-patch-1 branch August 13, 2018 09:14
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 13, 2018
@benoitf benoitf added this to the 6.10.0 milestone Aug 13, 2018
@ghost ghost mentioned this pull request Aug 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riuvshin riuvshin riuvshin approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@garagatyi garagatyi Awaiting requested review from garagatyi

@l0rd l0rd Awaiting requested review from l0rd

Assignees

@musienko-maxim musienko-maxim

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@musienko-maxim @riuvshin @sleshchenko @benoitf