Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: fix unstable selenium tests from dashboard and miscellaneous packages #10786

Merged
merged 3 commits into from Aug 15, 2018
Merged

Selenium: fix unstable selenium tests from dashboard and miscellaneous packages #10786

merged 3 commits into from Aug 15, 2018

Conversation

SkorikSergey
Copy link
Contributor

@SkorikSergey SkorikSergey commented Aug 15, 2018 •
edited by dmytro-ndp

What does this PR do?

This PR does some fixes to unstable tests:

  • add info about known issue The "Rename method" form does not close during timeout  #10784 to Refactor selenium page object;
  • move WorkspacesListTest to one-thread-suite because in multi-thread mode other selenium tests can change expected number of all created workspaces;
  • add checking that the Loader is closed after the Project Explorer is visible.

@SkorikSergey SkorikSergey added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/che-qe labels Aug 15, 2018
@SkorikSergey SkorikSergey merged commit d37d9b8 into master Aug 15, 2018
@SkorikSergey SkorikSergey deleted the fixUnstableSeleniumTests branch August 15, 2018 14:04
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 15, 2018
@benoitf benoitf added this to the 6.10.0 milestone Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SkorikSergey @dmytro-ndp @benoitf