CHE_INFRASTRUCTURE and CHE_MULTIUSER vars can be now passed as system #10801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
benoitf
added
the
status/code-review
properties. Signed-off-by: Radim Hopp <rhopp@redhat.com>
rhopp
commented
Aug 16, 2018
| @@ -128,12 +128,6 @@ public boolean test(Map.Entry<K, V> entry) { | |||
| name = name.replace('_', '.'); | |||
| name = name.replace("=", "_"); | |||
|
|
|||
| // convert value of CHE_INFRASTRUCTURE to upper case to comply with Infrastructure | |||
There was a problem hiding this comment.
As now, the che.infrastructure can be defined also as system property, I had to move this logic somewhere else (InMemoryTestConfiguration). If the new place is not the best one, please let me know.
|
Looks good for me. Lets run CI tests. |
dmytro-ndp
approved these changes
Aug 16, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before this PR, properties
CHE_MULTIUSERandCHE_INFRASTRUCTUREhad to be set as environmental variables. After this PR is merged, it will be possible to set them as system variables.In other words - before this PR, it was not possible to start tests with
-Dche.infrastructure=openshiftfor example... After this PR this should be possible.From my testing, this PR should not break any flow (a.k.a. setting env variable
CHE_INFRASTRUCTUREwill be enough)What issues does this PR fix or reference?
Release Notes
Docs PR