Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce java language server #10863

Merged
merged 237 commits into from
Oct 17, 2018
Merged

Introduce java language server #10863

merged 237 commits into from
Oct 17, 2018

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Aug 21, 2018 •
edited by tsmaeder
Loading

Switches Java support in Che 6 to be jdt.ls based:

Reference issue

Switch Java infrastructure to JDT LS #6157

What does this PR do?

Adds java language server

Companion PR's.

eclipse-che/che-parent#87
eclipse-che/che-lib#111
eclipse-che/che-docs#404

@tolusha tolusha added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. status/in-progress This issue has been taken by an engineer and is under active development. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/languages labels Aug 21, 2018
@tsmaeder tsmaeder requested a review from a user August 21, 2018 14:55
@tsmaeder tsmaeder changed the title [WIP] Introduce java language server Introduce java language server Sep 14, 2018
@dmytro-ndp
Copy link
Contributor

ci-test

@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
docker image: eclipseche/che-server:10863
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:10863
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

tsmaeder and others added 22 commits October 17, 2018 14:26
@tsmaeder
Fix formatting
4230c99 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Fix formatting
75dd07f 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Avoid timeout in tree expansion by deferring build command
50f32b1 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Ignore stale element references when getting editor contents
e66b8be 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Update goto symbol result to observed correct behaviour
2349a5a 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Fix expected char offset in test
6d91a3e 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Fix open location to select range (#11436)
848628c 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Adapt "open declaration" tests to behaviour of LSP editors (#11448)
faeb9f5 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Adapt jdt.ls as a lsp editor when opening locations (#11449)
f1abfab 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Fixup after rebase
a0ec8be 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Wait for jdt.ls, remove changes vs. master, adopt observed behavior
1636ec5 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@Ohrimenko1988 @tsmaeder
Remove redundant steps (#11534)
1346ae4 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@tsmaeder
Fix handling of workspace paths in find implementations (#11551)
ad45604 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Fix NPE when no signature help is available (#11550)
1cbec50 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Fix stacks ci tests, allow wait for multiple jdltls resolve msg (#11517)
caf48fa 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@svor @tsmaeder
Add binding for Java Code Formatter (#11491)
15ea6e7 
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@tsmaeder
Make sure we udpate local projects when importing or on startup (#11598)
4c8f80e 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Use che-ls-jdt 0.0.1
a84aa8f 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Fix formatting
b1e26f9 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Fix bogus merge
f9d3e25 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Fix merge error
1c1d362 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Fix formatting
29f01db 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder tsmaeder merged commit 58dc906 into master Oct 17, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 17, 2018
@benoitf benoitf added this to the 6.13.0 milestone Oct 17, 2018
@l0rd
Copy link
Contributor

l0rd commented Oct 17, 2018

🎉🎉🎉🎉🎉🎉🎉

This was referenced Oct 29, 2018
Merged
Closed
@benoitf benoitf deleted the 5730_java_ls_poc branch November 30, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riuvshin riuvshin riuvshin left review comments

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 left review comments

@tsmaeder tsmaeder tsmaeder approved these changes

@dmytro-ndp dmytro-ndp dmytro-ndp left review comments

@ashumilova ashumilova Awaiting requested review from ashumilova

@benoitf benoitf Awaiting requested review from benoitf

@garagatyi garagatyi Awaiting requested review from garagatyi

@l0rd l0rd Awaiting requested review from l0rd

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

@vparfonov vparfonov Awaiting requested review from vparfonov

@dkuleshov dkuleshov Awaiting requested review from dkuleshov

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

Assignees

@svor svor

@tolusha tolusha

@tsmaeder tsmaeder

Labels
kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Milestone
6.13.0
Development

Successfully merging this pull request may close these issues.

None yet