Imrove code readability by following sonar lint guidance #11247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
equalsIgnoreCase() call. Signed-off-by: Aurélien Pupier <apupier@redhat.com>
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
configured" 3 times. Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
force-pushed
the
ImroveCodeReadabilityByFollowingSonarLintGuidance
branch
from
3b1dbf2
to
8a33b99
Compare
|
ci-build |
mshaposhnik
approved these changes
Sep 17, 2018
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
benoitf
added
the
status/code-review
skabashnyuk
approved these changes
Sep 19, 2018
|
@mshaposhnik @eclipse/eclipse-che-qa can you take a look on test results and merge pr? |
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/819/) doesn't show any regression against this Pull Request. |
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Release Notes
Docs PR