Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce RC version for pre-release testing #11477

Merged
merged 3 commits into from Oct 4, 2018
Merged

introduce RC version for pre-release testing #11477

merged 3 commits into from Oct 4, 2018

Conversation

riuvshin
Copy link
Contributor

@riuvshin riuvshin commented Oct 4, 2018

@riuvshin riuvshin self-assigned this Oct 4, 2018
@riuvshin riuvshin requested a review from benoitf as a code owner October 4, 2018 11:15
@riuvshin riuvshin requested a review from a user October 4, 2018 11:18
benoitf
benoitf approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but I didn't tested

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 4, 2018
@riuvshin
Copy link
Contributor Author

riuvshin commented Oct 4, 2018

since we do not have ci coverage for dockerfiles I've tested this PR manually, it works as expected, when I select rc image it uses all images tagged with rc tag (similar to other tags)

Revert "fixup"
335bdad 
This reverts commit 86a13e4.
@riuvshin riuvshin merged commit b4244e0 into master Oct 4, 2018
@riuvshin riuvshin deleted the cli_versions branch October 4, 2018 11:28
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 4, 2018
@benoitf benoitf added this to the 6.12.0 milestone Oct 4, 2018
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 4, 2018
@nickboldt
introduce RC version for pre-release testing (eclipse-che#11477)
ec79338 
* introduce RC version for pre-release testing
* move utility images to cli version
* use maven central instead of codenvycorp nexus in dev image
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 5, 2018
@nickboldt
introduce RC version for pre-release testing (eclipse-che#11477)
fd61ca8 
* introduce RC version for pre-release testing
* move utility images to cli version
* use maven central instead of codenvycorp nexus in dev image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

Assignees

@riuvshin riuvshin

Labels
None yet
Projects
None yet
Milestone
6.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@riuvshin @benoitf