Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cause information in LoggedRunnable error #11602

Merged
merged 1 commit into from Oct 12, 2018
Merged

Add cause information in LoggedRunnable error #11602

merged 1 commit into from Oct 12, 2018

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Oct 12, 2018

What does this PR do?

Add cause information in case of InvocationTargetException | IllegalAccessException happened in LoggedRunnable
Example

Disconnected from the target VM, address: '127.0.0.1:52852', transport: 'socket'
2018-10-12 09:40:09,672[main]             [ERROR] [o.e.c.c.s.e.LoggedRunnable 66]       - null
java.lang.reflect.InvocationTargetException: null
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.che.commons.schedule.executor.LoggedRunnable.run(LoggedRunnable.java:58)
	at org.eclipse.che.commons.schedule.executor.LoggedRunnableTest.TestLoggedRunnable(LoggedRunnableTest.java:14)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:85)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:696)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:882)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1189)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:124)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
	at org.testng.TestRunner.privateRun(TestRunner.java:767)
	at org.testng.TestRunner.run(TestRunner.java:617)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305)
	at org.testng.SuiteRunner.run(SuiteRunner.java:254)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
	at org.testng.TestNG.run(TestNG.java:1057)
	at org.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:72)
	at org.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:123)
Caused by: java.lang.RuntimeException: java.lang.NullPointerException
	at org.eclipse.che.commons.schedule.executor.LoggedRunnableTest$TestObject.go(LoggedRunnableTest.java:28)
	... 29 common frames omitted
Caused by: java.lang.NullPointerException: null
	... 30 common frames omitted

What issues does this PR fix or reference?

n/a

Release Notes

n/a

Docs PR

n/a

@skabashnyuk
Copy link
Contributor Author

ci-test

@skabashnyuk skabashnyuk changed the title Add cause information in LoggedRunnable Add cause information in LoggedRunnable error Oct 12, 2018
@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Oct 12, 2018
@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11602
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk skabashnyuk merged commit 518c5f2 into master Oct 12, 2018
@skabashnyuk skabashnyuk deleted the morelogs branch October 12, 2018 10:40
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 12, 2018
@benoitf benoitf added this to the 6.13.0 milestone Oct 12, 2018
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 15, 2018
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants