Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing java support in Camel stack #11651

Merged
merged 1 commit into from Oct 21, 2018
Merged

Add missing java support in Camel stack #11651

merged 1 commit into from Oct 21, 2018

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Oct 17, 2018

Signed-off-by: Aurélien Pupier apupier@redhat.com

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

@apupier
Copy link
Contributor Author

apupier commented Oct 17, 2018

ci-test

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 17, 2018
@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11651
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@apupier
Copy link
Contributor Author

apupier commented Oct 17, 2018

error on CI seems unrelated to my modification:

 1) TypeScript Check Invalid Syntax:
17:03:32      CypressError: Timed out retrying: Expected to find element: '.monaco-inputbox>.wrapper>.input', but never found it.
17:03:32       at Object.cypressErr (http://localhost:3000/__cypress/runner/cypress_runner.js:68052:11)

@apupier
Copy link
Contributor Author

apupier commented Oct 17, 2018

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11651
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@apupier
Copy link
Contributor Author

apupier commented Oct 18, 2018 •
edited

this time is failed on another unrelated stuff:

18:09:11 ================================================================================
18:09:11 
18:09:11   (Run Finished)
18:09:11 
18:09:11 
18:09:11       Spec                                    Tests  Pass…  Fail…  Pend…  Skip… 
18:09:11   ┌────────────────────────────────────────────────────────────────────────────┐
18:09:11   │ ✖ theia/commands.spec.ts          00:26      3      -      3      -      - │
18:09:11   ├────────────────────────────────────────────────────────────────────────────┤
18:09:11   │ ✖ theia/typescript.spec.ts        00:17      1      -      1      -      - │
18:09:11   └────────────────────────────────────────────────────────────────────────────┘
18:09:11     2 of 2 failed (100%)              00:44      4      -      4      -      -  
18:09:11 
18:09:11 [INFO] 
18:09:11 [INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @ che-core-commons-inject ---
18:09:11 [INFO] 
18:09:11 [INFO] -------------------------------------------------------
18:09:11 [INFO]  T E S T S
18:09:11 [INFO] -------------------------------------------------------
18:09:11 �[?25h[INFO] Running TestSuite
18:09:12 SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
18:09:12 SLF4J: Defaulting to no-operation (NOP) logger implementation
18:09:12 SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
18:09:12 [ERROR] Command execution failed.
18:09:12 org.apache.commons.exec.ExecuteException: Process exited with an error: 4 (Exit value: 4)
18:09:12 	at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404)
18:09:12 	at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166)
18:09:12 	at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:804)
18:09:12 	at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:751)
18:09:12 	at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:313)
18:09:12 	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
18:09:12 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
18:09:12 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
18:09:12 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
18:09:12 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
18:09:12 	at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:185)
18:09:12 	at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:181)
18:09:12 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
18:09:12 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
18:09:12 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
18:09:12 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
18:09:12 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
18:09:12 	at java.lang.Thread.run(Thread.java:745)

same error as this other PR: https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1005/console

@apupier
Copy link
Contributor Author

apupier commented Oct 18, 2018

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11651
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@apupier
Copy link
Contributor Author

apupier commented Oct 18, 2018

about the label "enhancement", it is no tan enhancement it is to fix a regression introduced when jdt.ls has been merged

@apupier
Copy link
Contributor Author

apupier commented Oct 18, 2018

ci-build

@apupier
Copy link
Contributor Author

apupier commented Oct 19, 2018

ci-test

@apupier
Add missing java support in Camel stack
017a475 
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier force-pushed the fixCamelStackWhichMustContainJava branch from 1cace4b to 017a475 Compare October 19, 2018 12:54
@apupier
Copy link
Contributor Author

apupier commented Oct 19, 2018

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11651
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@apupier
Copy link
Contributor Author

apupier commented Oct 21, 2018

all camel related tests passed.
There are 45 failures reported but seems not related to this PR.

@benoitf benoitf merged commit 3db150f into eclipse-che:master Oct 21, 2018
@benoitf benoitf added this to the 6.13.0 milestone Oct 21, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 21, 2018
@apupier apupier deleted the fixCamelStackWhichMustContainJava branch October 21, 2018 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@ashumilova ashumilova Awaiting requested review from ashumilova

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
6.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apupier @riuvshin @benoitf