Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: Change the 'waitNode()' method in the 'AssistantFindPanel' #11737

Merged
merged 4 commits into from Oct 26, 2018
Merged

Selenium: Change the 'waitNode()' method in the 'AssistantFindPanel' #11737

merged 4 commits into from Oct 26, 2018

Conversation

artaleks9
Copy link
Contributor

What does this PR do?

  • Rework the waitNode() in the AssistantFindPanel using the waitNoExceptions()
    from the SeleniumWebDriverHelper to avoid unexpected StaleElementReferenceException

What issues does this PR fix or reference?

#11730

@artaleks9 artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Oct 25, 2018
@artaleks9
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11737
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11737
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor Author

ci-test

dmytro-ndp
dmytro-ndp reviewed Oct 26, 2018
View reviewed changes
.../che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/AssistantFindPanel.java Outdated
}
return false;
}),
ELEMENT_TIMEOUT_SEC,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ELEMENT_TIMEOUT_SEC = 20 sec would not be enough, because just one iteration inside the for-loop can last up to getActionNodesCount:LOAD_PAGE_TIMEOUT_SEC + isActionNodeContainsText:LOAD_PAGE_TIMEOUT_SEC = 20 sec.

@dmytro-ndp dmytro-ndp changed the title Selenium: Change the 'waitNode() method in the 'AssistantFindPanel' Selenium: Change the 'waitNode()' method in the 'AssistantFindPanel' Oct 26, 2018
@artaleks9 artaleks9 merged commit fd6304e into master Oct 26, 2018
@artaleks9 artaleks9 deleted the che#11730 branch October 26, 2018 11:06
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 26, 2018
@benoitf benoitf added this to the 6.14.0 milestone Oct 26, 2018
@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11737
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.14.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@artaleks9 @riuvshin @dmytro-ndp @SkorikSergey @benoitf