Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: Add the 'try-catch' to the 'GitCompareTest' according to the known issue #11769 #11770

Merged
merged 7 commits into from Nov 2, 2018
Merged

Selenium: Add the 'try-catch' to the 'GitCompareTest' according to the known issue #11769 #11770

merged 7 commits into from Nov 2, 2018

Conversation

artaleks9
Copy link
Contributor

@artaleks9 artaleks9 commented Oct 29, 2018 •
edited

What does this PR do?

What issues does this PR fix or reference?

#11769
#11791

@artaleks9 artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Oct 29, 2018
@artaleks9
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11770
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor Author

ci-test

dmytro-ndp
dmytro-ndp reviewed Nov 1, 2018
View reviewed changes
selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/CodenvyEditor.java Outdated
*
* @param positionLine line's number where cursor should be placed
*/
public void goToLine(int positionLine) {
Copy link
Contributor

@dmytro-ndp dmytro-ndp Nov 1, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name goToLine() has the same meaning as setCursorToLine(), IMHO.
I would rename goToLine() to moveCursorToLine().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I don't mind

@riuvshin
Copy link
Contributor

riuvshin commented Nov 1, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11770
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor Author

ci-test

@artaleks9 artaleks9 merged commit c67c12e into master Nov 2, 2018
@artaleks9 artaleks9 deleted the che#11769 branch November 2, 2018 12:18
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 2, 2018
@benoitf benoitf added this to the 6.14.0 milestone Nov 2, 2018
@riuvshin
Copy link
Contributor

riuvshin commented Nov 2, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11770
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
6.14.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@artaleks9 @riuvshin @dmytro-ndp @SkorikSergey @benoitf