CHE-1160: Update Vagrantfile #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the Vagrantfile to now launch the Che Docker container instead of Che as a server. Simpler syntax, more reliable, and operates as a Daemon by default "--restart=always" syntax.
added 2 commits
May 17, 2016 14:18
1. Added check for vagrant proxy plugin install. 2. Writes proxy configuration details into che.properties if they are present. 3. Launches Che container with provided che.properties instead of default. 4. Give the user the ability to change the port that the VM is listening on and map it to internal port 8080
|
Build # 608 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/608/ to view the results. |
|
Build # 614 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/614/ to view the results. |
|
LGTM |
Added port mapping capability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the Vagrantfile to now launch the Che Docker container instead of Che as a server. Simpler syntax, more reliable, and operates as a Daemon by default "--restart=always" syntax. Also adds in better checks for Vagrant plugin configuration. Maps Che workspaces and projects into the Vagrant image sync'd folder. Also now lets the user set the port that the image is listening on.
Updated 4.3 documentation: https://eclipse-che.readme.io/v4.3/docs/usage-vagrant
@eivantsov @riuvshin - please approve.