Update che.sh #1329
Merged
Update che.sh #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2016 14:01
Add in catch all error message.
|
|
||
| # CHE-1202: Improve error messages in case of docker ps failure | ||
| # Verify that /var/run/docker.sock has owner and group read / write permissions | ||
| PERMS=$(stat -c %A /var/run/docker.sock) |
There was a problem hiding this comment.
- Even if docker.sock has owner/group rw permission it doesn't mean that current user is owner or included in needed group.
- docker.sock can have rw permission for others.
sudo chmod 660 /var/run/docker.sockwill help only when user has needed id or gid
There was a problem hiding this comment.
We perform the uid check elsewhere in the script. It is checked before getting to this step.
|
@garagatyi Added formatting. |
|
Build # 664 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/664/ to view the results. |
|
LGTM |
|
Please use squash when you will be ready to merge |
|
@eivantsov Added check for other group. |
|
+1 |
|
Build # 678 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/678/ to view the results. |
AndrienkoAleksandr
added a commit
to eclipse-che/che-theia
that referenced
this pull request
May 7, 2019
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
added a commit
to eclipse-che/che-theia
that referenced
this pull request
May 13, 2019
* Use cwd for terminal creation Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Use cwd only for editor container. Limited by eclipse-che/che#1329 Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Clean up. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_1 Upvote_ CHE-1202 - Add in checks in case 'docker ps' fails. There are two additional checks. First, verify that group and owner have rw permissions for /var/run/docker.sock. Second, verify that the docker client version and the docker server version match. In situations where docker client is in a Che container and that container is using a host's docker daemon, it is possible for the client and server to not match.
@garagatyi, @eivantsov what do you think?
I don't have a way to generate good tests for this. I did the best that I could in a VM, but all the VMs I create generally don't have either of these issues. Do we have good environments to test for this improvement?