Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore account linking on newest keycloak versions #13398

Merged
merged 1 commit into from
May 23, 2019
Merged

Conversation

mshaposhnik
Copy link
Contributor

What does this PR do?

Since in newer Keycloak versions meaning of aud claim changed a little, so it is not contains name of the client who requested token anymore. This information is stored in the azp claim value, which is right place for it (see https://www.iana.org/assignments/jwt/jwt.xhtml). So we must read it from here.

What issues does this PR fix or reference?

#13380

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
@mshaposhnik
Copy link
Contributor Author

ci-test

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented May 22, 2019

@mshaposhnik: thanks for quick fixup!
CRW 1.2 requires having this fix in 6.19.x branch as well.
Could you, please, create separate PR to merge fixup into 6.19.x branch?

@mshaposhnik
Copy link
Contributor Author

@dmytro-ndp usually we do cherry-picks from master after commit is merged.

@che-bot
Copy link
Contributor

che-bot commented May 22, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13398
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

E2E selenium tests results for github integration look good.

@dmytro-ndp
Copy link
Contributor

@mshaposhnik: I have created PR #13401 to make it possible to test it as Che 6.x using CRW 1.2.

@mshaposhnik mshaposhnik merged commit c90a529 into master May 23, 2019
@mshaposhnik mshaposhnik deleted the fixOAuth branch May 23, 2019 07:33
@matskiv
Copy link

matskiv commented Jun 7, 2019

Is this change backwards compatible with RH SSO 7.2?

I am having problems with GitHub auth via SSO 7.2.
Client [che-client] not authorized to retrieve tokens from identity provider [github].
Same "che-client" worked in the past.

@matskiv
Copy link

matskiv commented Jun 7, 2019

nvm, my problem was caused by incorrect client roles (fix).
Sorry for spam. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants