Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the jwt-proxy memory as a part of stack's globalMemoryLimit #14270

Merged
merged 1 commit into from Aug 21, 2019
Merged

Add the jwt-proxy memory as a part of stack's globalMemoryLimit #14270

merged 1 commit into from Aug 21, 2019

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Aug 17, 2019 •
edited

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Add the 'jwt-proxy' memory as a part of stack's globalMemoryLimit for all stack lists for UD.

What issues does this PR fix or reference?

#14001

@olexii4
Copy link
Contributor Author

olexii4 commented Aug 17, 2019

ci-test

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 17, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 17, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 17, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14270
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@eclipse-che eclipse-che deleted a comment from che-bot Aug 19, 2019
@olexii4
Copy link
Contributor Author

olexii4 commented Aug 19, 2019

ci-test

@SkorikSergey
Copy link
Contributor

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14270
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4
add the jwt-proxy memory as a part of stack's globalMemoryLimit
35a5ea6 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
Copy link
Contributor Author

olexii4 commented Aug 19, 2019

ci-test

@olexii4
Copy link
Contributor Author

olexii4 commented Aug 19, 2019

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14270

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14270

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14270
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2032//Selenium_20tests_20report/) doesn't show any regression against this Pull request.

AndrienkoAleksandr
AndrienkoAleksandr reviewed Aug 20, 2019
View reviewed changes
dashboard/src/components/api/devfile-registry.factory.ts
if (!memoryLimit) {
return -1;
}
const regExpExecArray = /^([0-9]+)([a-zA-Z]{1,3})$/.exec(memoryLimit);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to improve regexp using values from enum MemoryUnit, but up to you.

Copy link
Contributor Author

@olexii4 olexii4 Aug 20, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check the MemoryUnit in this place of code
https://github.com/eclipse/che/pull/14270/files/35a5ea6771cc28eee7506acaf132e17cc93bf51a#diff-6296915bbb52eb6ee7111f8e2fd1e2feR126
In this case, it will be simpler to change something - just change the units enum in the head of the file
https://github.com/eclipse/che/pull/14270/files/35a5ea6771cc28eee7506acaf132e17cc93bf51a#diff-6296915bbb52eb6ee7111f8e2fd1e2feR24

@olexii4 olexii4 merged commit bc1920f into master Aug 21, 2019
@olexii4 olexii4 deleted the CHE-14001 branch August 21, 2019 08:35
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 21, 2019
@che-bot che-bot added this to the 7.1.0 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evidolob evidolob evidolob approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

@mmorhun mmorhun Awaiting requested review from mmorhun

@ashumilova ashumilova Awaiting requested review from ashumilova

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@olexii4 @che-bot @SkorikSergey @evidolob @AndrienkoAleksandr @akurinnoy