Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility class to operate with arrays #1443

Merged
merged 1 commit into from
Jun 7, 2016
Merged

Add utility class to operate with arrays #1443

merged 1 commit into from
Jun 7, 2016

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Jun 6, 2016

There is a proposal to add an utility class which helps easily operate with arrays.

This PR is part of #1383.

@vparfonov @skabashnyuk please, review it.

Related issue: CHE-907

@codenvy-ci
Copy link

Build # 816 - FAILED

Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/816/ to view the results.


for (int index = 0; index < array.length; index++) {
if (array[index] == o) {
return index;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make one statement instead of two?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparison has changed to use with guava method com.google.common.base.Objects#equal

@skabashnyuk
Copy link
Contributor

ok

1 similar comment
@vparfonov
Copy link
Contributor

ok

Signed-off-by: Vladyslav Zhukovskii <vzhukovskii@codenvy.com>
@vzhukovs vzhukovs merged commit 0c37bc3 into master Jun 7, 2016
@vzhukovs vzhukovs deleted the CHE-907-arrays branch June 7, 2016 07:00
@codenvy-ci
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants