Fixes space issue with profile variables #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJewell
added
kind/bug
This was referenced Sep 23, 2016
Closed
|
Build # 503 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/503/ to view the results. |
|
Added this request. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/506/ |
benoitf
approved these changes
Sep 23, 2016
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* initial * env variable usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue in CLI where default variables with spaces were not read properly from a default profile. It also adds in a fix that if values from a default profile are loaded and passed into che-launcher, they do so with the appropriate double quotes.
What issues does this PR fix or reference?