New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hotkey for expand/collapse project tree #3083
Conversation
* @since 5.0.0 | ||
*/ | ||
public abstract class TreeCollapseAction extends Action { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TreeCollapseAction -> CollapseTreeAction
* @since 5.0.0 | ||
*/ | ||
public abstract class TreeExpandAction extends Action { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TreeExpandAction -> ExpandTreeAction
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1035/ |
} | ||
}); | ||
|
||
final TreeExpander treeExpander = new TreeExpander() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move it to dedicate class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -0,0 +1,65 @@ | |||
/******************************************************************************* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What reason have this class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a factory for common actions, at this moment for collapse/expand tree. It can be used to create dynamic actions that should not be registered in the ActionManager
but displayed on the any tree you want.
For now, it is possible to call expand/collapse all actions via calling native js function:
|
Build # 1053 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1053/ to view the results. |
* Add hotkey for expand/collapse project tree * Add unit tests for the actions * Move project explorer tree expander to dedicate class * Expose external JS API * Typo fix * Add new line
Add ability to expand or collapse project tree by calling hotkey:
Linux/Windows:
Ctrl+[
for expand allCtrl+]
for collapse allOSX:
Command+[
for expand allCommand+]
for collapse allRelated issue: codenvy/qa#347
Needed for QA internal purposes.
@vparfonov review it, please.