[cli] Compare date but by having a delta of 1hour #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ished date are not the same (some time is elapsed before publishing an image locally (transfer time) Change two lines to a single line Instead of "local is older", display that "a newer version is available" exact message is : "WARN: There is a newer eclipse/che-cli:nightly image on DockerHub." Fix CODENVY-1235 Change-Id: I80bb2f8c48995b5dd06ecd3cff84009b76fceee7 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
benoitf
added
kind/bug
TylerJewell
approved these changes
Dec 15, 2016
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1336/ |
skabashnyuk
approved these changes
Dec 15, 2016
benoitf
removed
the
status/code-review
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…ished date are not the same (some time is elapsed before publishing an image locally (transfer time) (eclipse-che#3404) Change two lines to a single line Instead of "local is older", display that "a newer version is available" exact message is : "WARN: There is a newer eclipse/che-cli:nightly image on DockerHub." Fix CODENVY-1235 Change-Id: I80bb2f8c48995b5dd06ecd3cff84009b76fceee7 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
codenvy/codenvy#1235
Previous behavior
Compare published date and created date (that have delta)
New behavior
As created date and published date are not the same (there is always a delay before publishing an image locally (transfer time) we couldn't compare published date and created date
Change two lines to a single line
Instead of "local is older", display that "a newer version is available"
exact message is : "WARN: There is a newer eclipse/che-cli:nightly image on DockerHub."
Change-Id: I80bb2f8c48995b5dd06ecd3cff84009b76fceee7
Signed-off-by: Florent BENOIT fbenoit@codenvy.com