Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODENVY-937: stop buttons behavior based on auto-snapshot settings #3419

Merged
merged 1 commit into from
Jan 17, 2017

Conversation

ashumilova
Copy link
Contributor

Signed-off-by: Ann Shumilova ashumilova@codenvy.com

What does this PR do?

  1. Displays caption on workspace details stop button based on workspace auto-snapshot settings. It can be "Stop" or "Stop without snapshot"
  2. Adds one more stop button to context menu (which does opposite in context of create-snapshot behavior).
  3. On running workspace deletion - the workspace is alsways stopped without snapshot creation.

What issues does this PR fix or reference?

codenvy/codenvy#937
#3159

@codenvy-ci
Copy link

Build # 1356 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1356/ to view the results.

@codenvy-ci
Copy link

Build # 1382 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1382/ to view the results.

@TylerJewell
Copy link

@ashumilova - lets plan to get this merged in current sprint, or if not, please add into next sprint.

Signed-off-by: Ann Shumilova <ashumilova@codenvy.com>

Conflicts:
	dashboard/src/components/api/che-workspace.factory.ts
@ashumilova ashumilova added this to the 5.1.0 milestone Jan 17, 2017
@ashumilova ashumilova merged commit 66ef4f9 into master Jan 17, 2017
@ashumilova ashumilova deleted the CODENVY-937 branch January 17, 2017 09:23
@codenvy-ci
Copy link

@JamesDrummond JamesDrummond mentioned this pull request Jan 31, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants