CHE-2514 add import stack popup #3518
Conversation
| } | ||
|
|
||
| /** | ||
| * Update imported stack if it valid. |
There was a problem hiding this comment.
Update imported stack if it is valid.
| * @param stack {che.IStack} | ||
| * @returns {IValidation} | ||
| */ | ||
| getStackValidation(stack: che.IStack | {}): IValidation { |
There was a problem hiding this comment.
Should this method be in separate service? I think it could be used not only for stack import.
| * @param workspaceConfig {che.IWorkspaceConfig} | ||
| * @returns {IValidation} | ||
| */ | ||
| getWorkspaceConfigValidation(workspaceConfig: che.IWorkspaceConfig): IValidation { |
There was a problem hiding this comment.
Same question for this method
| * @param environment {che.IWorkspaceEnvironment} | ||
| * @returns {IValidation} | ||
| */ | ||
| getEnvironmentValidation(environment: che.IWorkspaceEnvironment): IValidation { |
There was a problem hiding this comment.
Same question for this method
| * @param machine {che.IMachine} | ||
| * @returns {IValidation} | ||
| */ | ||
| getMachineValidation(machine: che.IMachine): IValidation { |
There was a problem hiding this comment.
Same question for this method
| * @param recipe {che.IRecipe} | ||
| * @returns {IValidation} | ||
| */ | ||
| getRecipeValidation(recipe: che.IRecipe): IValidation { |
There was a problem hiding this comment.
Same question for this method
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1457/ |
|
Stevan: should Composefile be a single word to be consistent with Dockerfile? |
|
Yes agree, you are right. @OOleksii could you update please? |
|
@olexii4 : Have you updated the label on the button? |
| <che-toggle ng-model="importStackController.recipeFormat" ng-change="importStackController.updateType()" | ||
| md-theme="default"> | ||
| <che-toggle-button che-title="Dockerfile" che-value="{{importStackController.DOCKERFILE}}"></che-toggle-button> | ||
| <che-toggle-button che-title="Compose file" |
There was a problem hiding this comment.
Change button name, please.
| } else if (COMPOSE_FILE === recipe.type) { | ||
| if (!/^services:\n/m.test(recipe.content)) { | ||
| isValid = false; | ||
| errors.push('The compose file is invalid.'); |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1467/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1514/ |
|
Build # 1521 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1521/ to view the results. |
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
|
Build # 1559 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1559/ to view the results. |
slemeur
added
kind/enhancement
CHE-2514 add import stack popup
Signed-off-by: Oleksii Orel oorel@codenvy.com
What does this PR do?
Add import stack popup.
#2514