Loads a new git history page when user scrolled list to the very bottom #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Promise<LogResponse> log(DevMachine devMachine, Path project, Path[] fileFilter, boolean plainText); | ||
|
|
||
| /** | ||
| * Get log of commits. The result is the list of {@link Revision}, which is returned by callback in |
There was a problem hiding this comment.
which is returned by callback
can't see any callback here 😸
| private void fetchHistoryPage(final boolean append) { | ||
| service.log(appContext.getDevMachine(), | ||
| project.getLocation(), | ||
| null, |
There was a problem hiding this comment.
null is passed but log method's javadoc says nothing about it.
I think it would be nice to have documented this possibility.
| @@ -87,17 +91,15 @@ | |||
| Button btnDiffWithWorkTree; | |||
| @UiField | |||
| Button btnDiffWithPrevCommit; | |||
| @UiField | |||
| ScrollPanel scrollPanel; | |||
vzhukovs
reviewed
Dec 28, 2016
| Promise<LogResponse> log(DevMachine devMachine, Path project, Path[] fileFilter, boolean plainText); | ||
|
|
||
| /** | ||
| * Get log of commits. The result is the list of {@link Revision}, which is returned by callback in | ||
| * <code>onSuccess(Revision result)</code>. |
There was a problem hiding this comment.
Paraphrase this sentence, this api method returns a promise, it doesn't operate with callbacks.
vzhukovs
reviewed
Dec 28, 2016
| @@ -87,17 +91,15 @@ | |||
| Button btnDiffWithWorkTree; | |||
| @UiField | |||
| Button btnDiffWithPrevCommit; | |||
| @UiField | |||
| ScrollPanel scrollPanel; | |||
There was a problem hiding this comment.
Apply formatter to this piece of code
vzhukovs
approved these changes
Dec 28, 2016
|
@azatsarynnyy |
azatsarynnyy
approved these changes
Dec 28, 2016
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1480/ |
vparfonov
approved these changes
Dec 28, 2016
vinokurig
approved these changes
Dec 28, 2016
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…om (eclipse-che#3553) CHE-3353: Pagination in loading git history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pagination at loading git history
What issues does this PR fix or reference?
#3353
Previous behavior
All git history was loaded at one request and blocked ide.
New behavior
Loads git history by page when user scrolled list to the very bottom
Please review Che's Contributing Guide for best practices.