Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load instance runtime information on machine start #3561

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

voievodin
Copy link
Contributor

Machine runtime information is lazy-loaded and loading happens when workspace runtime information is requested first time. So basically it is possible to meet the state when workspace machine will be RUNNING but Instance.getRuntime won't return anything because it's the first call to get workspace runtime and there is a problem like the following:

org.eclipse.che.plugin.docker.client.exception.DockerException:
Error response from docker API, status: 500, message: Get 
http://node6.codenvy.io:2375/containers/<id>/json: dial tcp <ip:port>: i/o timeout

The changes introduced in the pull request load machine runtime information on machine start, ones it's loaded machine data is in consistent state with its status, if loading fails machine start will be also considered as failed.
Along with that workspace start problems are logged as warnings, e.g. if docker file is broken.

Fixes codenvy-1320.

@codenvy-ci
Copy link

@codenvy-ci
Copy link

@codenvy-ci
Copy link

@voievodin voievodin merged commit 8674d22 into master Jan 10, 2017
@voievodin voievodin deleted the fix_runtimes_npe branch January 10, 2017 21:48
@slemeur slemeur added kind/enhancement A feature request - must adhere to the feature request template. and removed status/pending-merge labels Jan 18, 2017
@JamesDrummond JamesDrummond mentioned this pull request Jan 31, 2017
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants