Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor workspace infrastructure provisioning #3577

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Refactor workspace infrastructure provisioning #3577

merged 1 commit into from
Jan 11, 2017

Conversation

garagatyi
Copy link

What does this PR do?

Move agents volume addition into infrastructure provisioner.
Suppress some false positive warnings.
Add some javadocs.

What issues does this PR fix or reference?

Related to codenvy/codenvy#1149

Tests written?

No

@codenvy-ci
Copy link

Build # 1490 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1490/ to view the results.

@garagatyi
Copy link
Author

ci-build

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1513/

sleshchenko
sleshchenko approved these changes Jan 5, 2017
View reviewed changes
...orkspace/src/main/java/org/eclipse/che/api/environment/server/InfrastructureProvisioner.java
/**
* Modifies machine config and internal machine representation with everything needed for infrastructure of workspace.
*
* @param machineConfig configuration of machine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix formatting here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@garagatyi
Copy link
Author

ci-build

@codenvy-ci
Copy link

Build # 1531 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1531/ to view the results.

@codenvy-ci
Copy link

Build # 1536 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1536/ to view the results.

@codenvy-ci
Copy link

Build # 1542 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1542/ to view the results.

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1568/

Refactor workspace infrastructure provisioning
f4a0e16 
Move agents volume addition into infrastructure provisioner.
Suppress some false positive warnings.
Add some javadocs.
Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
@garagatyi garagatyi merged commit f4ade80 into eclipse-che:master Jan 11, 2017
@garagatyi garagatyi deleted the CODENVY-1149 branch January 11, 2017 13:56
@codenvy-ci
Copy link

Build # 1575 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1575/ to view the results.

@slemeur slemeur added this to the 5.1.0 milestone Jan 18, 2017
@slemeur slemeur added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jan 18, 2017
@JamesDrummond JamesDrummond mentioned this pull request Jan 31, 2017
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@voievodin voievodin voievodin approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@akorneta akorneta akorneta approved these changes

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@garagatyi @codenvy-ci @skabashnyuk @voievodin @sleshchenko @akorneta @slemeur