CHE-3578: set focus on terminal after resizing #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vparfonov I suppose that this PR will break changes made by this previous commit 3da5a96#diff-e15936ac6286c2e6559b1194493b5b30L245 Because this method is called when terminal first time appears on the UI (when IDE starts). |
vparfonov
approved these changes
Jan 10, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1560/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1571/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1576/ |
slemeur
added
the
kind/bug
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets focus on the terminal after resizing.
What issues does this PR fix or reference?
#3578
Previous behavior
Focus is lost when the terminal was minimized or maximized
New behavior
Focus sets when size of the terminal is changed