Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert cli nightly image check #3688

Merged
merged 3 commits into from
Jan 12, 2017
Merged

revert cli nightly image check #3688

merged 3 commits into from
Jan 12, 2017

Conversation

riuvshin
Copy link
Contributor

needed for #3684
revert CLI nightly image check because it was not working on different OS or docker storage driver.

@benoitf
Copy link
Contributor

benoitf commented Jan 12, 2017

I've following error testing it:

INFO: (che cli): Loading cli...
expr: non-integer argument
/scripts/base/cli/cli-functions.sh: line 416: [[: 2017-01-11T23: value too great for base (error token is "11T23")
WARN: (che init): 'nightly' installations cannot be upgraded to non-nightly versions
INFO: (che cli): Checking registry for version 'nightly' images

@riuvshin
Copy link
Contributor Author

@benoitf sorry my bad, I've missed to use timestamp_date_iso8601

benoitf
benoitf approved these changes Jan 12, 2017
View reviewed changes
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@riuvshin riuvshin merged commit f7ca10c into master Jan 12, 2017
@riuvshin riuvshin deleted the cli_rever_nightly_check branch January 12, 2017 11:16
riuvshin pushed a commit that referenced this pull request Jan 12, 2017
revert cli nightly image check (#3688)
17de15f 
* revert cli nightly image check
@codenvy-ci
Copy link

Build # 1597 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1597/ to view the results.

@slemeur slemeur modified the milestone: 5.1.0 Jan 17, 2017
@slemeur slemeur added the kind/bug Outline of a bug - must adhere to the bug report template. label Jan 17, 2017
@JamesDrummond JamesDrummond mentioned this pull request Jan 31, 2017
Closed
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
revert cli nightly image check (eclipse-che#3688)
cfae192 
* revert cli nightly image check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@TylerJewell TylerJewell Awaiting requested review from TylerJewell

@garagatyi garagatyi Awaiting requested review from garagatyi

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@riuvshin @benoitf @codenvy-ci @slemeur