Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-3120: Add Sourcegraph Python Language Server to Che #3693

Merged
merged 4 commits into from
Jan 12, 2017
Merged

Conversation

vparfonov
Copy link
Contributor

What does this PR do?

Add Sourcegraph Python Language Server to Che

What issues does this PR fix or reference?

#3120

Evgen Vidolob and others added 2 commits January 11, 2017 16:14
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
@codenvy-ci
Copy link

Build # 1603 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1603/ to view the results.

@vparfonov
Copy link
Contributor Author

python_ls_che

Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
@vparfonov
Copy link
Contributor Author

ci-build

Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
@codenvy-ci
Copy link

@vparfonov vparfonov merged commit 64625bc into master Jan 12, 2017
@vparfonov vparfonov deleted the che#3120 branch January 12, 2017 21:38
@vparfonov vparfonov self-assigned this Jan 12, 2017
@vparfonov vparfonov added this to the 5.1.0 milestone Jan 12, 2017
@slemeur slemeur added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 17, 2017
@JamesDrummond JamesDrummond mentioned this pull request Jan 31, 2017
9 tasks
@bmicklea
Copy link

bmicklea commented Feb 2, 2017

@vparfonov - I'm trying to write the release notes for this but I can't find any intellisense for Python in codenvy.io, even after I turn on the language server with our Python stack and sample app. What are the types of intellisense that this adds for Python and how is it triggered?

@vparfonov
Copy link
Contributor Author

@bmicklea Current version of Sourcegraph Python Language Server doesn't provide any intellisense in classic means. For now it's support only hover feature https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#hover-request

@bmicklea
Copy link

bmicklea commented Feb 3, 2017

Okay, for some reason the hover didn't work for me either (I saw it in your video). Thanks for clarifying.

@ymatagne
Copy link

Hello,
Nice Job. This is very interesting for python 3.6.

But, i've the impression that python language server doesn't work with python 2.7 ?

Thanks,

@bmicklea
Copy link

@ymatagne the Sourcegraph Python LS that we're using says that it works for Python 3.x and 2.x. Is something not working for you?

@ymatagne
Copy link

@bmicklea Yes, Python Ls don't work with Python 2.X.

If you want reproduce:

  1. Select Python 2.7 stack in stack view
  2. Active Sourcegraph Python LS
  3. Click to Test button

When workspace is open, you cannot create project or update project. In log file, there isn't error.

I try with Mac and Windows with Che 5.2.2.

Thanks,

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
…3693)

Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants