revert back pulling CLI if local image older than 24h #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
approved these changes
Jan 12, 2017
|
We need to do testing on this again - changed the logic. |
|
Fixes #3684 |
benoitf
reviewed
Jan 12, 2017
| @@ -381,12 +381,14 @@ function verify_nightly_accuracy() { | |||
| # than the one stored on DockerHub. | |||
| if is_nightly; then | |||
|
|
|||
| REMOTE_NIGHTLY_JSON=$(curl -s https://hub.docker.com/v2/repositories/${CHE_IMAGE_NAME}/tags/nightly/) | |||
| # REMOTE_NIGHTLY_JSON=$(curl -s https://hub.docker.com/v2/repositories/${CHE_IMAGE_NAME}/tags/nightly/) | |||
There was a problem hiding this comment.
we can drop the commented line
benoitf
approved these changes
Jan 12, 2017
riuvshin
pushed a commit
that referenced
this pull request
Jan 12, 2017
* revert back pulling CLI if local image older than 24h
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1609/ |
slemeur
added
the
kind/bug
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* revert back pulling CLI if local image older than 24h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after I've reverted f7ca10c this I've also removed logic which do pull CLI and exit if CLI is older than 24h
so I'm adding it back with this PR.