Fix bug in CLI Output if user has overridden CHE_HOST #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJewell
added
kind/bug
garagatyi
reviewed
Jan 16, 2017
| info "${CHE_PRODUCT_NAME}_HOST = ${CHE_HOST}" | ||
| local CHE_HOST_LOCAL=${CHE_HOST} | ||
| if is_initialized; then | ||
| CHE_HOST_LOCAL=$(docker_run --env-file="${REFERENCE_CONTAINER_ENVIRONMENT_FILE}" \ |
There was a problem hiding this comment.
Maybe create function that retrieves variable by name? It is possible that other variables in different places will be also needed at some point
There was a problem hiding this comment.
Yeah, that is a good idea. Let me think about how to do such a thing.
benoitf
approved these changes
Jan 16, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1649/ |
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* added utility function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue uncovere by @garagatyi where the CLI output in two locations shows the wrong CHE_HOST value if the user has overridden CHE_HOST in the che.env file.
This implements a printout mechanism that uses Docker to print out the value and passes in
che.envas an input into that.