Skip failed project resolving in case if the last one is empty #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
added
kind/bug
Update is not needed here, because incoming project already contains project type information
JamesDrummond
added
status/code-review
ashumilova
approved these changes
Jan 17, 2017
added 3 commits
January 17, 2017 17:19
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1659/ |
vzhukovs
removed
the
status/code-review
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…se-che#3767) * Skip failed project resolving in case if the last one is empty * Remove redundant project update Update is not needed here, because incoming project already contains project type information * Check is composer.json file exist before parse it Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal fixes that bug when user is trying to import an empty project through the UI. In this case project resolving fails with 500 Internal server error, client side should process this exception without any warning dialogs, but server side should be also return empty estimation list on empty project.
This PR fixes only client side.
Related issue: #3766