Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language in exception message #4915

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

Shan1024
Copy link
Contributor

@Shan1024 Shan1024 commented Apr 25, 2017

What does this PR do?

This PR updates the language in the exception message from CSharp to Python.

What issues does this PR fix or reference?

N/A

Changelog

Updates the language in the exception message from CSharp to Python.

Release Notes

N/A

Docs PR

N/A

@codenvy-ci
Copy link

Can one of the admins verify this patch?

@benoitf
Copy link
Contributor

benoitf commented Apr 28, 2017

Hello @Shan1024 could you sign the Eclipse CLA ? so we can merge your fix ?
https://dev.eclipse.org/eclipse-webhook/services/status_details.php?id=58ffaab4b0dde

@Shan1024
Copy link
Contributor Author

Shan1024 commented Apr 28, 2017

@benoitf : I used my company email before to sign the CLA, that's why this validation failed. After I used my personal email and signed the CLA again. Is there any way to trigger the validation again?

@benoitf
Copy link
Contributor

benoitf commented Apr 28, 2017

@Shan1024 you can amend your commit and add Signed-off-by: footer in the commit message (git commit -s --amend)

This commit changes the exception message from CSharp to Python.

Signed-off-by: shan1024 <gambit1024@gmail.com>
@Shan1024
Copy link
Contributor Author

@benoitf : Thanks. I have amended the commit.

@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Apr 28, 2017
@benoitf benoitf added this to the 5.10.0 milestone Apr 28, 2017
@benoitf
Copy link
Contributor

benoitf commented Apr 28, 2017

@Shan1024 thanks

@benoitf
Copy link
Contributor

benoitf commented Apr 28, 2017

ci-build

@codenvy-ci
Copy link

@riuvshin riuvshin removed this from the 5.10.0 milestone May 10, 2017
@gazarenkov gazarenkov removed the request for review from JamesDrummond June 14, 2017 19:19
@benoitf benoitf added this to the 5.13.0 milestone Jun 14, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 14, 2017
@benoitf benoitf merged commit ac2f395 into eclipse-che:master Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants