Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates per issue #495

Merged
merged 2 commits into from
Feb 24, 2016
Merged

Updates per issue #495

merged 2 commits into from
Feb 24, 2016

Conversation

TylerJewell
Copy link

  1. Update to use latest /assembly format.
  2. Add in the logback logger to eliminate unnecessary errors
  3. Fix error in IF logic around skipping maven check.
  4. Add in printing of all used directories in debug mode.

@TylerJewell
Copy link
Author

@skabashnyuk Please ok this - needed to fix some issues with users building plug-ins.

Signed-off-by: Tyler Jewell <tjewell@codenvy.com>
@riuvshin
Copy link
Contributor

@TylerJewell you have to sign your commit.

@TylerJewell
Copy link
Author

@riuvshin Actually, we got confirmation from Eclipse Foundation that committers do not need to sign. Only contributors. The "All checks have failed" issue is a bug with the Eclipse integration and they said that we can ignore it if we know a committer has issued the PR.

@riuvshin
Copy link
Contributor

@TylerJewell yeah I know but this looks like a bug and it's better to sign to pass this validation.

@TylerJewell
Copy link
Author

@riuvshin Actually, the previous commit was signed:
14b3ff8 and the error still exists. I think we are safe to merge.

@riuvshin
Copy link
Contributor

@TylerJewell yeah, I see, looks like a bug

TylerJewell pushed a commit that referenced this pull request Feb 24, 2016
@TylerJewell TylerJewell merged commit 97e173d into master Feb 24, 2016
@TylerJewell TylerJewell deleted the che-591 branch February 24, 2016 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants