Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-5040:Replace md5 calculation for avoid problem with big files #5090

Merged
merged 2 commits into from
May 17, 2017

Conversation

vparfonov
Copy link
Contributor

Signed-off-by: Vitalii Parfonov vparfonov@codenvy.com

What does this PR do?

Replace md5 calculation for avoid problem with big files

What issues does this PR fix or reference?

#5040

Changelog

Replace md5 calculation for avoid problem with big files

Release Notes

N/A

Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
@vparfonov vparfonov added kind/bug Outline of a bug - must adhere to the bug report template. team/ide labels May 16, 2017
@vparfonov vparfonov added this to the 5.11.0 milestone May 16, 2017
@vparfonov vparfonov requested a review from dkuleshov May 16, 2017 10:32
@benoitf
Copy link
Contributor

benoitf commented May 16, 2017

It looks like there is a missing test

Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
@vparfonov
Copy link
Contributor Author

@benoitf I've don't add any new functionality

@benoitf
Copy link
Contributor

benoitf commented May 16, 2017

@vparfonov what is telling me that there is no regression after the change ?

@vparfonov
Copy link
Contributor Author

@benoitf nightly QA circle

@benoitf
Copy link
Contributor

benoitf commented May 16, 2017

integration test is too late and is not appropriate for such things.

@vparfonov
Copy link
Contributor Author

i will test before merge it

@codenvy-ci
Copy link

@vparfonov vparfonov merged commit 19360a0 into master May 17, 2017
@vparfonov vparfonov deleted the che#5040 branch May 17, 2017 07:04
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
…lipse-che#5090)

* Replace md5 calculation for avoid problem with big files

Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants