CHE-4197: Apply CHE_DOCKER_ALWAYS__PULL__IMAGE to container creation #5112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2017 08:56
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2615/ |
garagatyi
approved these changes
May 17, 2017
| @@ -518,7 +520,9 @@ protected void pullImage(CheServiceImpl service, | |||
|
|
|||
| try { | |||
| boolean isSnapshot = SNAPSHOT_LOCATION_PATTERN.matcher(dockerMachineSource.getLocation()).matches(); | |||
| if (!isSnapshot || snapshotUseRegistry) { | |||
| boolean isImageExistLocally = isDockerImageExistLocally(dockerMachineSource.getRepository()); | |||
| if (!isSnapshot && (doForcePullImage || !isImageExistLocally) || | |||
There was a problem hiding this comment.
In my opinion, this code would be more clear if operands wouldn't rely on remembering operations priority. E.g. next equivalent code looks clearer for me:
(!isSnapshot && (doForcePullImage || !isImageExistLocally) || isSnapshot && snapshotUseRegistry)
There was a problem hiding this comment.
I divided this with new line, but I do not mind about brackets. Let be so.
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
bmicklea
added
the
kind/enhancement
bmicklea
approved these changes
May 17, 2017
|
Build # 2619 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2619/ to view the results. |
skabashnyuk
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Takes into account
CHE_DOCKER_ALWAYS__PULL__IMAGEvalue when creating docker container for a workspace machine. This means, that if the property is set tofalsethen Che won't try to pull image for a container if it exists locally.What issues does this PR fix or reference?
#4197
Changelog
Respect the value of CHE_DOCKER_ALWAYS__PULL__IMAGE when creating containers.
Release Notes
We've improved the behavior of Che when it's run in a secure environment disconnected from the internet. In the
che.envthere is a propertyCHE_DOCKER_ALWAYS_PULL_IMAGEthat when sent tofalsewill ensure that Che only checks the local (private) registry for the Docker image. The default value istrueand in this case Che will always check DockerHub for a newer image version before creating the container.