Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Stack for Java-MySql on CentOS (based on the Openshift MySql docker image) #5227

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

davidfestal
Copy link
Contributor

What does this PR do?

Add a Stack for Java-MySql on CentOS (based on the Openshift MySql docker image)

What issues does this PR fix or reference?

This issue provides a Java - MySql stack that can be used in Che on Openshift.
This is related to the work done for issue https://issues.jboss.org/browse/CHE-175

@ashumilova ashumilova added the target/branch Indicates that a PR will be merged into a branch other than master. label May 29, 2017
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@davidfestal
Copy link
Contributor Author

@l0rd @sunix could you review this PR please ?

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"creator": "ide",
"name": "Java-MySQL CentOS",
"description": "Multi-machine environment with Java CentOS Stack and MySQL database",
"scope": "general",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a general one or more an "advanced" one ?

@davidfestal
Copy link
Contributor Author

@benoitf sorry, in fact mabne it should no be there and probably not merged into the Che master stacks. I have to discuss this again with @l0rd and this PR might need to be closed without being merged.

@davidfestal davidfestal changed the base branch from openshift-connector to master May 31, 2017 08:28
Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal
Copy link
Contributor Author

@benoitf I adapted this PR to be merged on the master branch, and changed the stack scope from general to advanced

@benoitf benoitf requested a review from slemeur May 31, 2017 09:15
@benoitf benoitf removed the target/branch Indicates that a PR will be merged into a branch other than master. label May 31, 2017
@davidfestal
Copy link
Contributor Author

davidfestal commented Jun 2, 2017

@slemeur any idea about this one ?

@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jun 2, 2017
@davidfestal
Copy link
Contributor Author

davidfestal commented Jun 6, 2017

Can anyone merge this ?

@sunix sunix merged commit 9426d5d into eclipse-che:master Jun 8, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 14, 2017
@slemeur slemeur added this to the 5.12.0 milestone Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants