Exclude non-source directories from java project #523
Conversation
If java project (not maven) has language attributem then we search source folder definition in attributes and if no one was found then dont mark folder as source folder. Relevant issue: CHE-589 (Broken project tree). Signed-off-by: Vladyslav Zhukovskii <vzhukovskii@codenvy.com>
| if (!attributes.containsKey(srcAttribute)) { | ||
| return ""; | ||
| return null; |
There was a problem hiding this comment.
Why do you return "" and null when srcAttribute doesn't have value?
https://github.com/eclipse/che/pull/523/files#diff-6063db316be1e2733d888f9686ae3133R98
There was a problem hiding this comment.
Because maven project (which is java simultaneously) should have source folder definition, in this case it will be defined or empty, if empty, then we'll mark root folder as source. If project is java (not maven), then source folder may not be defined, if so, then we don't mark any folder as source.
There was a problem hiding this comment.
It's a temporary solution, which I think will be refactored after GA.
|
Also, Why do you not add number of issue to commit message? |
|
I've added the issue number, see the description. |
|
Oh, Yeah. Sorry. It is unusually to see number of issue in body of commit message. Earlier we added it to subject of commit message |
vzhukovs
added
the
kind/bug
|
ok |
Exclude non-source directories from java project
If java project (not maven) has language attribute, then we search source folder definition in attributes and if no one was found then dont mark folder as source folder.
Relevant issue: CHE-589 (Broken project tree).
Signed-off-by: Vladyslav Zhukovskii vzhukovskii@codenvy.com
@vparfonov