Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-5247: fix cmd download and cmd offline #5263

Merged
merged 1 commit into from
Jun 1, 2017
Merged

CHE-5247: fix cmd download and cmd offline #5263

merged 1 commit into from
Jun 1, 2017

Conversation

riuvshin
Copy link
Contributor

@riuvshin riuvshin commented Jun 1, 2017

What does this PR do?

fix offline mode, download and save all needed images.

What issues does this PR fix or reference?

Fixes: #5247

Changelog

fix offline mode, download and save all needed images.

@riuvshin riuvshin added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 1, 2017
@riuvshin riuvshin added this to the 5.12.0 milestone Jun 1, 2017
@riuvshin riuvshin requested review from benoitf and a user June 1, 2017 13:34
@riuvshin riuvshin merged commit 5f26c06 into master Jun 1, 2017
@riuvshin riuvshin deleted the fix_offline branch June 1, 2017 13:58
@codenvy-ci
Copy link

Build # 2733 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2733/ to view the results.

@Anne369
Copy link

Anne369 commented Jun 4, 2017

@riuvshin I see the build is failed, when I should get a fixed build

@riuvshin
Copy link
Contributor Author

riuvshin commented Jun 4, 2017

hi @Anne369 , please just ignore that build failed message from CI, this happend because I've merged and deleted a branch during PR build check :)
this fix is already in master so you could test it with nightly version or wait for upcoming release (mid next week)

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I download the che for offline on Mac, it continue failed on che-action
4 participants