Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-4007: Remove deprecation in GitHubClientService #5322

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jun 9, 2017

What does this PR do?

Remove deprecated methods in GitHubClientService class

What issues does this PR fix or reference?

fixes #4007

Changelog

Removed deprecated methods in GitHubClientService class

Release Notes

Technical debt N/A

Docs PR

Technical debt N/A

@codenvy-ci
Copy link

Build # 2775 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2775/ to view the results.

@vinokurig
Copy link
Contributor Author

[TEST]
[TEST] RESULTS ANALYSE:
[TEST]
[TEST] Command line: ./webdriver.sh --test=com.codenvy.ide.git.*
[TEST]
[TEST] Local results:
[TEST] 	- Run: 	     30
[TEST] 	- Failed:     3
[TEST]
[TEST] REGRESSION (3):
[TEST] 	com.codenvy.ide.git.ImportRecursiveSubmoduleTest.checkImportProjectSubmoduleByHttpsUrl
[TEST] 	com.codenvy.ide.git.ImportRecursiveSubmoduleTest.checkImportProjectSubmoduleBySshUrl
[TEST] 	com.codenvy.ide.git.ImportRecursiveSubmoduleTest.checkImportProjectSubmoduleFromGithub
[TEST]

[TEST] STABLE TESTS EXECUTION RESULTS ANALYSE:
[TEST]
[TEST] Command line: ./webdriver.sh --compare-with-ci
[TEST]
[TEST] CI results https://ci.codenvycorp.com/view/qa/job/che-integration-tests/363/
[TEST] 	- Failed:    81 (unique tests)
[TEST]
[TEST] Local results:
[TEST] 	- Run: 	      30
[TEST] 	- Failed:     3
[TEST] 	com.codenvy.ide.git.ImportRecursiveSubmoduleTest.checkImportProjectSubmoduleByHttpsUrl
[TEST] 	com.codenvy.ide.git.ImportRecursiveSubmoduleTest.checkImportProjectSubmoduleBySshUrl
[TEST] 	com.codenvy.ide.git.ImportRecursiveSubmoduleTest.checkImportProjectSubmoduleFromGithub
[TEST]
[TEST] Comparing with https://ci.codenvycorp.com/view/qa/job/che-integration-tests/363/
[TEST] If a test failed then it is NOT marked as regression.
[TEST]
[TEST] NO REGRESSION! CHECK THE FAILED TESTS. THEY MIGHT FAIL DUE TO DIFFERENT REASON.
[TEST]
[TEST]

@vinokurig vinokurig added this to the 5.12.0 milestone Jun 13, 2017
@vinokurig vinokurig merged commit fe60e9f into master Jun 13, 2017
@vinokurig vinokurig deleted the CHE-4007 branch June 13, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecation in GitHubClientService
4 participants