CHE-274 - Improve idling implementation #5425
Conversation
|
Can one of the admins verify this patch? |
|
|
@snjeza I've added the template for PR descriptions here with hidden HTML comments on what each section means. Please fill it in as well as you can and I will review. |
|
@bmicklea I have updated the PR description. |
|
I think there's a typo in the changelog - it should be 3,600,000 not 360,000 right? And I noticed this is changed in che-properties, but is there an option added to Also, please add a label for |
sunix
added
the
kind/enhancement
| * [2012] - [2017] Codenvy, S.A. | ||
| * All Rights Reserved. | ||
| * | ||
| * NOTICE: All information contained herein is, and remains |
There was a problem hiding this comment.
copyright seems to be wrong. it should be EPL
| * is strictly forbidden unless prior written permission is obtained | ||
| * from Codenvy S.A.. | ||
| */ | ||
| package org.eclipse.che.api.agent.server.activity; |
There was a problem hiding this comment.
in che, copyrights are EPL
There was a problem hiding this comment.
I have updated the PR.
|
ci-build |
|
Build # 2909 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2909/ to view the results. |
|
@snjeza we need to do appropriate changes in codenvy to reuse this code. please do not merge until we will be ready. |
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
ci-build |
|
Build # 2920 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2920/ to view the results. |
|
@benoitf There is a newer build - https://ci.codenvycorp.com/job/che-pullrequests-build/2920 |
|
let's restart the build on jenkins |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2934/ |
is someone working on this ? |
|
@sunix : iI suppose it's @skabashnyuk team |
|
Copied content from this PR into new one: #5512 |
What does this PR do?
Enable workspace shutdown after a specified inactivity period.
What issues does this PR fix or reference?
https://issues.jboss.org/browse/CHE-274
Changelog
Added the che.machine.ws.agent.inactive.stop.timeout.ms=3600000 and stop.workspace.scheduler.period property
Release Notes
Per default, a workspace will be stopped after one hour of inactivity.
Docs PR
N/A
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com
See #5386