Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LSP for pom editor #5641

Merged
merged 1 commit into from Jul 14, 2017
Merged

Use LSP for pom editor #5641

merged 1 commit into from Jul 14, 2017

Conversation

tsmaeder
Copy link
Contributor

What does this PR do?

This PR removes the custom Maven pom editor and uses the LSP-based editor instead. In order to achieve this, it introduces a Maven language server that runs in the ws-agent process. Maven problems are communicated as LSP diagnostics instead of custom problem instances.
The reason for this PR is to open up the pom editor for extension by additional language servers, in particular, the bayesian language server on OSIO.

What issues does this PR fix or reference?

#5492

Changelog

Use language server protocol editor for pom.xml files

Release Notes

This should be transparent to the user.

Docs PR

No change

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder tsmaeder requested a review from evidolob as a code owner July 14, 2017 09:44
@tsmaeder tsmaeder requested a review from vparfonov July 14, 2017 09:44
@tsmaeder tsmaeder self-assigned this Jul 14, 2017
@tsmaeder tsmaeder added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/californication labels Jul 14, 2017
@codenvy-ci
Copy link

Can one of the admins verify this patch?

1 similar comment
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@tsmaeder tsmaeder merged commit 2a57ca8 into eclipse-che:master Jul 14, 2017
@tsmaeder tsmaeder removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 14, 2017
@riuvshin
Copy link
Contributor

@tsmaeder this changes broke build https://ci.codenvycorp.com/job/che-ci-master/1552/console

20:39:11 /home/codenvy/workspace/che-ci-master/plugins/plugin-maven/che-plugin-maven-server/src/main/java/org/eclipse/che/plugin/maven/lsp/MavenTextDocumentService.java:33: error: MavenTextDocumentService is not abstract and does not override abstract method completion(TextDocumentPositionParams) in TextDocumentService
20:39:11 public class MavenTextDocumentService implements TextDocumentService {
20:39:11        ^
20:39:11 /home/codenvy/workspace/che-ci-master/plugins/plugin-maven/che-plugin-maven-server/src/main/java/org/eclipse/che/plugin/maven/lsp/MavenTextDocumentService.java:41: error: completion(TextDocumentPositionParams) in MavenTextDocumentService cannot implement completion(TextDocumentPositionParams) in TextDocumentService
20:39:11     public CompletableFuture<CompletionList> completion(TextDocumentPositionParams position) {
20:39:11                                              ^
20:39:11   return type CompletableFuture<CompletionList> is not compatible with CompletableFuture<Either<List<CompletionItem>,CompletionList>>
20:39:11 /home/codenvy/workspace/che-ci-master/plugins/plugin-maven/che-plugin-maven-server/src/main/java/org/eclipse/che/plugin/maven/lsp/MavenTextDocumentService.java:40: error: method does not override or implement a method from a supertype
20:39:11     @Override
20:39:11     ^

@riuvshin riuvshin added this to the 5.15.0 milestone Jul 14, 2017
@evidolob evidolob mentioned this pull request Jul 17, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants