Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TomEE 1.7.3 stack and sample application #570

Merged
merged 2 commits into from
Mar 3, 2016

Conversation

jgallimore
Copy link
Contributor

@jgallimore jgallimore commented Feb 29, 2016

_2 Upvotes_ Signed-off-by: Jonathan Gallimore jgallimore@tomitribe.com

This PR adds TomEE 1.7.3 as a stack, and a Tomitribe AngularJS / JAX-RS sample application as an example. Please let me know if you have any issues.

Signed-off-by: Jonathan Gallimore <jgallimore@tomitribe.com>
@slemeur
Copy link
Contributor

slemeur commented Feb 29, 2016

+1: Nice contribution. Glad to see TomEE in Che's default stacks/samples

"creator": "tomitribe",
"name": "TomEE",
"description": "Default Java Stack with JDK 8, Maven and Apache TomEE 1.7.3.",
"scope": "general",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be "advanced" instead of "general" where we only have one per technology : java, php, node, etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benoitf, Thanks for the feedback. I have updated!

Signed-off-by: Jonathan Gallimore <jgallimore@tomitribe.com>
@benoitf
Copy link
Contributor

benoitf commented Mar 3, 2016

+1

slemeur added a commit that referenced this pull request Mar 3, 2016
Add TomEE 1.7.3 stack and sample application
@slemeur slemeur merged commit dc1eeb6 into eclipse-che:master Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants