CHE-5236 Java debugger didn't highlight line in decompiled class #5808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolusha
requested review from
vzhukovs,
AndrienkoAleksandr,
bmicklea and
mmorhun
|
|
||
| BreakpointRenderer breakpointRenderer = getBreakpointRendererForEditor(editor); | ||
| if (breakpointRenderer != null) { | ||
| breakpointRenderer.setLineActive(currentBreakpoint.getLineNumber(), false); |
There was a problem hiding this comment.
Is this line really necessary?
There was a problem hiding this comment.
Agree, can be omitted
There was a problem hiding this comment.
To avoid multiple annotations it is better to remove active line at first.
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3179/ |
| } | ||
|
|
||
| protected void findSourceToOpen(Location location, AsyncCallback<VirtualFile> callback) { | ||
| findInProject(location, new AsyncCallback<VirtualFile>() { |
There was a problem hiding this comment.
Current code it's ok for me, but maybe findInProject, findInWorkspace, searchSource should return promise and then this code can be simplified a bit (less callbacks...)?
vzhukovs
approved these changes
Jul 26, 2017
AndrienkoAleksandr
approved these changes
Jul 26, 2017
mmorhun
approved these changes
Jul 26, 2017
bmicklea
added
the
kind/bug
vparfonov
approved these changes
Jul 27, 2017
dmytro-ndp
pushed a commit
to dmytro-ndp/che
that referenced
this pull request
Aug 16, 2017
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When debugger enters decompiled class then it waits for resources to be downloaded and then highlight the proper line
What issues does this PR fix or reference?
#5236
Changelog
Fix to Java debugger to highlight lines in decompiled sources.
Release Notes
not required
Docs PR
not required