Do not scale down deployment before resource deletion. Removing watch pod logic (seems to be also broken after 3.6 osio update) #6017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pod logic (seems to be also broken after 3.6 osio update) Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
skabashnyuk
reviewed
Aug 16, 2017
| @@ -41,26 +32,14 @@ | |||
| public class OpenShiftDeploymentCleaner { | |||
| private static final Logger LOG = LoggerFactory.getLogger(OpenShiftDeploymentCleaner.class); | |||
| private static final int OPENSHIFT_POD_DELETION_TIMEOUT = 120; | |||
| private static final int OPENSHIFT_WAIT_POD_DELAY = 1000; | |||
There was a problem hiding this comment.
shall we make this parameter configurable?
There was a problem hiding this comment.
this one is hot-fix. We will not this ugly delays in future
benoitf
approved these changes
Aug 16, 2017
benoitf
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Do not scale down deployment before resource deletion
deployment.scale(0, true);hangs on osio after update to 3.6 version. Watching pods also seem to hang till timeout occurs.Changelog
(bugfix, update to support OpenShift 3.6+)
Release Notes
N / A
Docs PR
N / A