Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-6114: Fix problems with project explorer performance in big projects #6175

Merged
merged 8 commits into from
Sep 12, 2017

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Sep 7, 2017

What does this PR do?

  1. Add ability to get Git status with filter.
  2. Reworked Injecting VCS status info in Project service to make Status request only once instead of requesting each time in the loop.
  3. Removed format parameter from get status method in Git Service, because it is redundant and do not affects to anything, since we use Jgit as a Git engine.

The main goal of calling git status with filter is to increase performance. Git status request without filter might be slow if project contains a lot of files.

What issues does this PR fix or reference?

fixes #6114

Changelog

Add ability to get Git status with filter

Release Notes

Fixed problems with project explorer performance in big project.

Docs PR

N/A

@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. kind/enhancement A feature request - must adhere to the feature request template. labels Sep 7, 2017
@vinokurig vinokurig changed the title CHE-6114: Fixe problems with project explorer performance in big project CHE-6114: Fix problems with project explorer performance in big project Sep 7, 2017
@vinokurig vinokurig changed the title CHE-6114: Fix problems with project explorer performance in big project CHE-6114: Fix problems with project explorer performance in big projects Sep 7, 2017
@codenvy-ci
Copy link

Build # 3579 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3579/ to view the results.

@davidwindell
Copy link
Contributor

👍

@skryzhny
Copy link

skryzhny commented Sep 8, 2017

@riuvshin can we have it in bugfix release?
I'm observing big increaser of CPU usage after updating to 5.17.0

@vinokurig
Copy link
Contributor Author

vinokurig commented Sep 8, 2017

@tolusha Reworked null filter parameter of Git status to emptyList()

@codenvy-ci
Copy link

Build # 3608 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3608/ to view the results.

@vinokurig
Copy link
Contributor Author

Checking QA results

@bmicklea
Copy link

@vparfonov will this be merged in this sprint?

@vinokurig
Copy link
Contributor Author

@bmicklea Selenium tests passed, I am going to merge it today

@codenvy-ci
Copy link

Build # 3642 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3642/ to view the results.

@codenvy-ci
Copy link

Build # 3643 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3643/ to view the results.

@codenvy-ci
Copy link

@vinokurig vinokurig merged commit fc35ba2 into master Sep 12, 2017
@vinokurig vinokurig deleted the CHE-6114 branch September 12, 2017 14:41
@davidwindell
Copy link
Contributor

Thanks for all the work on this @vinokurig

@codenvy-ci
Copy link

@vinokurig vinokurig added this to the 5.18.0 milestone Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspaces stuck consuming 100% CPU since 5.17
7 participants