Reworks CheckWsAgentAfterStopProcessTest test #6445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3823/ |
tolusha
reviewed
Sep 27, 2017
| @@ -38,18 +43,22 @@ | |||
| * @author Musienko Maxim | |||
| */ | |||
| public class CheckWsAgentAfterStopProcessTest { | |||
| private static final String PROJECT_NAME = CheckWsAgentAfterStopProcessTest.class.getSimpleName(); | |||
| private static final String PROJECT_NAME = | |||
| NameGenerator.generate("CheckWsAgentAfterStopProcessTest", 4); | |||
There was a problem hiding this comment.
NameGenerator.generate("project", 4);
tolusha
approved these changes
Sep 27, 2017
| @@ -38,18 +43,21 @@ | |||
| * @author Musienko Maxim | |||
| */ | |||
| public class CheckWsAgentAfterStopProcessTest { | |||
There was a problem hiding this comment.
I think we should rename the name of class because it a bit confuse. May be like: CheckResroingWorkspaceAfterStoppingWsAgentProcess or something like that. WDYF-?
| @Test | ||
| public void checkDialogAfterKillingProcess() throws Exception { | ||
| @Test(priority = 0) | ||
| public void checkWorkspaceRestartingByApi() throws Exception { | ||
| String expectedMessageOInDialog = |
There was a problem hiding this comment.
And name of method this one like: checkRestoreWsAgent
| } | ||
|
|
||
| @Test(priority = 1) | ||
| public void checkWorkspaceRestartingByIde() { | ||
| projectExplorer.waitItem(PROJECT_NAME); |
There was a problem hiding this comment.
And checkRestoreIdeItems()
tolusha
approved these changes
Sep 27, 2017
…storingWorkspaceAfterStoppingWsAgentProcess
vparfonov
approved these changes
Sep 27, 2017
|
Build # 3841 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3841/ to view the results. |
slemeur
added
the
kind/task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checking restarting of workspace by API and from the IDE in different tests.
What issues does this PR fix or reference?
#6442