Remove unnecessary tests from factory package #6458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slemeur
approved these changes
Sep 27, 2017
vparfonov
approved these changes
Sep 27, 2017
tolusha
approved these changes
Sep 27, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3844/ |
musienko-maxim
deleted the
remove_unnecessary_factory_tests_from_che
branch
slemeur
added
the
kind/task
This was referenced Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We've supported some specific examples from Bitnami for checking factory consuming. This factories were based on github direct urls with the specific repo. But this repos have been removed. On this moment i do not see sense for checking this factories, because we've already have very similar tests for check this functionality.
Also this tests may be very unstable and difficult to support.
@tolusha, @vparfonov, @slemeur