CHE-682: Enable debug buttons when debugger open file without source #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -211,7 +211,7 @@ public void initializeAndInitEditor() throws EditorInitException { | |||
|
|
|||
| embeddedTextEditorPresenter.injectAsyncLoader(loaderFactory); | |||
| embeddedTextEditorPresenter.initialize(configuration, notificationManager); | |||
| embeddedTextEditorPresenter.init(editorInput); | |||
| embeddedTextEditorPresenter.init(editorInput, null); | |||
There was a problem hiding this comment.
Ok, I'll fix it
AndrienkoAleksandr
force-pushed
the
CHE-682
branch
from
66dacf8
to
0209acb
Compare
| @@ -197,11 +198,17 @@ public void onReady(final String content) { | |||
| @Override | |||
| public void onError() { | |||
| displayErrorPanel(constant.editorInitErrorMessage()); | |||
| if (callback != null) { | |||
There was a problem hiding this comment.
I think yes, because for example in class RecipeEditorPanel we creates simple editor panel but we don't need OpenEditorCallback, or we can use empty implementation. What do you think?
Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
AndrienkoAleksandr
force-pushed
the
CHE-682
branch
from
0209acb
to
5ecd601
Compare
|
ok |
AndrienkoAleksandr
added a commit
that referenced
this pull request
Mar 10, 2016
CHE-682: Enable debug buttons when debugger open file without source
Katka92
pushed a commit
to Katka92/che
that referenced
this pull request
Jun 27, 2018
…h-che6 Revert "remove ability to override prod docker registry"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aleksandr Andrienko aandrienko@codenvy.com