-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heap on master filled with JSON-RPC message Strings #6676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
vparfonov
approved these changes
Oct 11, 2017
vparfonov
reviewed
Oct 11, 2017
private static final int MAX_MESSAGES = 100; | ||
|
||
private final WebSocketSessionRegistry registry; | ||
|
||
private final Map<String, List<String>> messagesMap = new HashMap<>(); | ||
private final Map<String, List<DelayedMessage>> delayedMessageRegistry = new HashMap<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConcurrentMap ?
skabashnyuk
approved these changes
Oct 11, 2017
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
vparfonov
approved these changes
Oct 11, 2017
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
Build # 4096 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4096/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmytro Kulieshov dkuliesh@redhat.com
What does this PR do?
Adds a scheduled task to clean stale
String
objectsWhat issues does this PR fix or reference?
#6663