Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heap on master filled with JSON-RPC message Strings #6676

Merged
merged 5 commits into from
Oct 11, 2017
Merged

Conversation

dkuleshov
Copy link

Signed-off-by: Dmytro Kulieshov dkuliesh@redhat.com

What does this PR do?

Adds a scheduled task to clean stale String objects

What issues does this PR fix or reference?

#6663

Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
@dkuleshov dkuleshov added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 11, 2017
private static final int MAX_MESSAGES = 100;

private final WebSocketSessionRegistry registry;

private final Map<String, List<String>> messagesMap = new HashMap<>();
private final Map<String, List<DelayedMessage>> delayedMessageRegistry = new HashMap<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConcurrentMap ?

Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
Dmytro Kulieshov added 2 commits October 11, 2017 15:27
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
@dkuleshov dkuleshov merged commit 6d71a32 into master Oct 11, 2017
@dkuleshov dkuleshov deleted the che#6663 branch October 11, 2017 13:31
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 11, 2017
@benoitf benoitf added this to the 5.19.0 milestone Oct 11, 2017
@codenvy-ci
Copy link

Build # 4096 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4096/ to view the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants