Remove unused SystemInfo attributes (cpu, freeMemory, totalMemory) #6946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I41bd108ce4b2af15693d57a5fa0c72caab932289 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
benoitf
added
status/code-review
|
as discussed on mattermost, some delay is required to ensure it's not used |
Change-Id: Icb2f6982bd31b8c6161c035827590286438e04f3 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4286/ |
benoitf
changed the title
skabashnyuk
approved these changes
Oct 25, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In Java9, relying on "internal fields" of classes is not permitted by default. Only public methods should be used.
The SystemInfo class is relying on "internal specific JDK" to get some cpu and memory attributes.
We could delete the JDK implementation and only uses the "Unix" implementation in the class but as it seems this code is never used, I would propose to remove it entirely.
What issues does this PR fix or reference?
#5326
Release Notes
N/A
Docs PR
N/A
Change-Id: I41bd108ce4b2af15693d57a5fa0c72caab932289
Signed-off-by: Florent BENOIT fbenoit@redhat.com