CHE-656: Refactor getOpenEditors method from Map to List

[vinokurig]

@vparfonov please review

[vzhukovs]

I think that passing VirtualFile as param to find the concrete editor will be better. Then to find specific editor you can compare virtual files with given one.

[vitaliy-guliy]

I prefer using the path. Why not?

[vzhukovs]

Because you can pass as string anything, when you're expecting specific file, then you couldn't pass any rubbish. It's easier to maintain the code.

[vitaliy-guliy]

Using the string is easier and understandable. Using the VirtualFile needs to write the special comparator to find. And what shall I do when I need to find an editor by the file path?

[vzhukovs]

Then use Path.java. We have specialized class to work with paths.

[vitaliy-guliy]

Why do we need Path.java ? Where is it used? Why did you decide to write so heavy class and used it only once ?

[ashumilova]

+1 for String path parameter

[vzhukovs]

Why did you decide to write so heavy class and used it only once ?

I use it in my branch everywhere, where it possible. It provides usefull support for paths. With less code writing. IMO.

For example, if you have smth like /path/to/file and you want to get project from this path, you should create bycicles with substrings, but your path may contains leading slash or not, may contains trailing slash or not. With this utility class you can simple do this: String project = Path.valueOf("path/to/file").segment(1); and get need value. Or if you want to get parent of the specified path, you just do this: Path.valueOf("/some/very/huge/path/to/file").parent() and get /some/very/huge/path/to.

Take a look on eclipse sources, how the developsers use it, and you'll understand. It really helpful for maintaining the resources.

Pros from using Path is that there is a basic path validation for input value and you wont be able to pass invalid value as file path

-1 for String path parameter

[vitaliy-guliy]

Ok.
+1 for String path parameter

[vinokurig]

I prefer to use String path parameter. There are many methods where getOpenedEditor(String path) used and this path directly received from their parameters.
@vparfonov what do you think?

[vparfonov]

I like idea with Path, looks useful (similar to java.nio.file). But i don't insist.

[vparfonov]

ok