Fixed replace_stacks.json after addition of dotnet-centos #7214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jpinkney <josh.pinkney@mail.utoronto.ca>
|
Can one of the admins verify this patch? |
benoitf
added
status/code-review
|
Can one of the admins verify this patch? |
benoitf
approved these changes
Nov 7, 2017
l0rd
approved these changes
Nov 7, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR proposes a fix for redhat-developer/rh-che#408.
replace_stacks.json was throwing a parse error because it was removing the comma after "org.eclipse.che.ws-agent" on this line: https://github.com/redhat-developer/rh-che/blob/master/assembly/fabric8-stacks/src/main/resources/stacks.json#L295 due to the sed at https://github.com/eclipse/che/blob/master/dockerfiles/init/modules/openshift/files/scripts/replace_stacks.sh#L47.
What issues does this PR fix or reference?
redhat-developer/rh-che#408
Release Notes
N/A